search

daattali / shinycssloaders

⌛ Add loading animations to a Shiny output while it's recalculating
https://daattali.com/shiny/shinycssloaders-demo/
Other
399 stars 45 forks source link

Feature request: allow type=0 #15

Closed sTeamTraen closed 4 years ago

sTeamTraen commented 6 years ago

This is indeed just a "WIBNI" (Wouldn't It Be Nice If...), but: it would be nice to allow the spinner type to be set to zero, which would display no spinner.

andrewsali commented 6 years ago

This sounds like a reasonable proposition, would you be interested in submitting a pull-request?

sTeamTraen commented 6 years ago

Very possibly, if I knew what a pull request was and what it involved me doing. I have 43 years of programming experience (if you want something doing in SNOBOL4, RTL/2, or RSX-11M assembler, I'm your man), and absolutely zero knowledge of Git. I will go and RTFM, or at least RTF beginner's guide.

daattali commented 4 years ago

I also like this idea, having 0 mean "nothing" is good design IMO. Looks like you did end up submitting a pull request #18 - thanks for that! And thanks for taking initiative and RTFM :)

daattali commented 4 years ago

This is solved by https://github.com/daattali/shinycssloaders/pull/18 - thanks