Suggestion: using more unique name than "assets" for client resource path

daattali / shinycssloaders

⌛ Add loading animations to a Shiny output while it's recalculating

https://daattali.com/shiny/shinycssloaders-demo/

Other

395 stars 45 forks source link

Suggestion: using more unique name than "assets" for client resource path #30

Closed lawrencecrane closed 4 years ago

lawrencecrane commented 5 years ago

shinycssloaders package currently adds/overwrites resource path "assets" (in R/globals.R). As this is quite generic path that Shiny apps themselves might want to use to store their assets/static content, then this package is not "compatible" with those.

Basically just a suggestion that could this be switched to more unique name, for example, shinycssloaders -- rather than assets?

daattali commented 4 years ago

I also noticed this https://github.com/daattali/shinycssloaders/issues/48 and fixed it last week.