search

daattali / shinycssloaders

⌛ Add loading animations to a Shiny output while it's recalculating
https://daattali.com/shiny/shinycssloaders-demo/
Other
395 stars 45 forks source link

Prevent bug / js error in case of undefined id #31

Closed bthieurmel closed 4 years ago

bthieurmel commented 5 years ago

In some case, id can be undefined, and so an error js is generated, and some outputs can be affected...! This little patch prevents that.

hillalex commented 5 years ago

NB: alternative solution here: https://github.com/andrewsali/shinycssloaders/pull/34

bthieurmel commented 4 years ago

Hi, There is still this error / problem with 0.3.0 shinycssloader. Why don't you accept this little new control, preventing some bug in some case ?

Thanks in advance.

daattali commented 4 years ago

@bthieurmel This project as you may have noticed was dormant for a while. I'm currently in the process of taking over as a maintainer. There weren't any issues files under github issues that said there were any problems with the current version, so I wanted to submit it to CRAN immediately so that people can start using the version that contained some fixes.

I haven't had a chance yet to go over the javascript in this pacakge, so I was going to go over this (and other) PRs afterwards. Now that I see that there was an (undocumented) issue in the code, this PR is obviously a priority! I can't promise I'll get to it in the next 2 weeks as I'm flying into RStudio Conference soon, but this will be looked at.

@bthieurmel and @hillalex - until I look at both of your PRs, if one of you looked at the other person's PR, let me know if you think one is better than the other please

daattali commented 4 years ago

I used a slightly different fix, but your PR inspired me for it. Thanks!

bthieurmel commented 4 years ago

Thanks. I confirm it's fix for me too.