search

daattali / shinycssloaders

⌛ Add loading animations to a Shiny output while it's recalculating
https://daattali.com/shiny/shinycssloaders-demo/
Other
395 stars 45 forks source link

Custom styling and HTML #60

Open jsicherman opened 3 years ago

jsicherman commented 3 years ago

Adds support for custom loaders via the addition of custom.class for specifying a CSS class name to add to the spinner, and custom.html, which allows users to specify custom HTML to provide to the spinner. Users just need to load their custom CSS as usual, pass in any necessary HTML elements and they're good to go.

daattali commented 2 years ago

Thanks for the PR, sorry I haven't found time to dedicate to this repo in a while.

custom.class is a good idea, but what do you think about it appending to the existing class names instead of overwriting? That way if someone wants to add some of their own css, they can add the CSS, set custom.class to whatever they want, and either choose to set custom.css to be TRUE or FALSE depending on whether they usecase is to completely rewrite the look or if it's only to modify it. The documentation for custom.class should probably mention that it works in tandem with custom.css in that case.

Regarding custom.html: could you provide an example usage?

PS say hi to Paul and Ogan from me!

daattali commented 1 year ago

@jsicherman I want to do some cleanup of old PRs - do you think you'll have time in 2023 to resolve this PR, or should we abandon it?

jsicherman commented 1 year ago

Hey! Sorry, I totally missed this and forgot about this PR. Will have a look at this again next week to see about getting it done and dusted :)

PS: what's your connection to the PavLab? Small world!

daattali commented 1 year ago

I did a rotation with Paul in 2013, and he also allowed me to use his lab space as my own when I did my masters with Jenny Bryan because she didn't have lab space. I always say he's one of the few real old school scientists I know :)

daattali commented 1 year ago

Let me know if you want to keep this PR alive

daattali commented 1 year ago

This package had a lot of changes in the last 2 months. If this PR isn't getting updated, I'll close it.