search

daattali / shinyjs

💡 Easily improve the user experience of your Shiny apps in seconds
https://deanattali.com/shinyjs
Other
734 stars 119 forks source link

hidden() doesn't work on a tagList() containing an htmlDependency() #252

Closed cpsievert closed 2 years ago

cpsievert commented 2 years ago

First reported in https://github.com/rstudio/shiny/issues/3670

Here's a minimal reprex

library(htmltools)

shinyjs::hidden(
  tagList(
    div(),
    htmlDependency(name = "foo", src = "", version = "1.0")
  )
)
daattali commented 2 years ago

Thanks for the report!

daattali commented 2 years ago

Fixed in both hidden() and disabled(). Please install latest github version and confirm it works in your usecase @gitdemont

gitdemont commented 2 years ago

It perfectly works ! THANKS 👍