search

daattali / shinyjs

💡 Easily improve the user experience of your Shiny apps in seconds
https://deanattali.com/shinyjs
Other
728 stars 119 forks source link

Disabled button still clickable with Vimium browser extension #272

Closed pietrodito closed 8 months ago

pietrodito commented 8 months ago

https://addons.mozilla.org/fr/firefox/addon/vimium-ff/

Disabled button cannot be clicked by mouse but can be 'clicked' by the vimium extension using the key f.

From vimium docs: "f - open a link in the current tab"

daattali commented 8 months ago

I think that's fine. There are always going to be ways to get around a disabled button. For example you can go into the DOM and remove the class that makes a button disabled. shinyjs can't cover all the possible bases, if someone is using an extension or any other explicit way to overcome a disabled button, then that's their choice.

It's important to understand that shinyjs works on the client side only, it should not be used as a security fix. If a button or a shiny input has serious security implications, it should always be checked in the server side.