daattali / timevis

📅 Create interactive timeline visualizations in R
http://daattali.com/shiny/timevis-demo/
Other
653 stars 157 forks source link

Issues with zooming when vis 4.20 is loaded (with visNetwork for example) #36

Closed DanielAbdelNour closed 3 years ago

DanielAbdelNour commented 6 years ago

The latest visNetwork updates use vis 4.20 which overrides timevis' vis 4.16. As a result, the zoom functionality breaks when zoomed to show months.

Here's a reproducible example (note the version numbers).

ps. Love your work, Dean :)

library(shiny)
library(timevis) #0.4.0.9000
library(visNetwork) #2.0.2

server <- function(input, output) {
   output$timevis <- renderTimevis({
      timevis()
   })

   output$visnet <- renderVisNetwork({
      visNetwork()
   })
}

ui <- fluidPage(
   useShinyjs(),
   sidebarLayout(
      sidebarPanel(),
      mainPanel(
         timevisOutput("timevis"),
         visNetworkOutput("visnet")
      )
   )
)

shinyApp(ui = ui, server = server)
daattali commented 6 years ago

Thanks for the report @DanielAbdelNour The initial title for this issue mentions a CSS class - did you actually track this down this issue to being caused by a css class? An update is due for timevis, but unfortunately every time I have 20 minutes to spare and I look into updating, I find some bugs caused by the update so I revert.

If anyone has some time and is able to help with updating to the latest timevis (and ensuring that all functionality still works), it would be a very welcomed pull request!

daattali commented 6 years ago

related to #32

daattali commented 6 years ago

related to #50

daattali commented 3 years ago

This would be fixed once I can upgrade to the latest version