Added necessary network.png for `timevis` to be supported in RMarkdown files

daattali / timevis

📅 Create interactive timeline visualizations in R

http://daattali.com/shiny/timevis-demo/

Other

653 stars 157 forks source link

Added necessary network.png for `timevis` to be supported in RMarkdown files #5

Closed charliejhadley closed 8 years ago

charliejhadley commented 8 years ago

Both CRAN and the development version of the library are missing the following directory from the vis.js library (from http://visjs.org/download/vis.zip)

dist/img/network

This results in failures when attempting to knit together a .Rmd file containing a timevis visualisation. Inserting these files into your library fixes the issue

daattali commented 8 years ago

Thank you @martinjhnhadley for taking a look at this and taking the initiative to fix! Your PR made me look a bit deeper into why it was failing in rmarkdown when I made sure to include all the relevant resources for the timeline module. I really wanted to "keep it clean" and not include any network module resources. Turns out the problem was that the CSS file had some rules that were referring to these network images, and even though those rules were never used in timelines, rmarkdown didn't like them being there at all. So instead of accepting this PR, I ended up just removing the network-specific CSS rules. Thank you for getting the ball rolling on fixing this :)