daattali / timevis

📅 Create interactive timeline visualizations in R
http://daattali.com/shiny/timevis-demo/
Other
652 stars 157 forks source link

Nesting Columns, as in nestedGroups is now supported #70

Closed strazto closed 5 years ago

strazto commented 5 years ago

Requires updates to vis>=4.18, or else won't change much

daattali commented 5 years ago

Thanks @mstr3336

Since this doesn't add any benefit right now (not your own fault as you know), I'm going to leave this open until it becomes relevant

strazto commented 5 years ago

Sure - I might go on to investigate the fold/unfold thing. That's ~probably more likely to be a problem specific to timevis, given that timevis does implement a few extra ui handlers, and it works well in js only cases.~ I was wrong it's a problem with vis.js / timeline plus

daattali commented 5 years ago

Sorry I don't actually know what the problem is, I haven't spent any time looking at this, I'm working on another few projects today. If you suspect the problem is because of timevis, maybe try to remove as many of the extra stuff I added and get it to be as basic as possible. timevisBasic might be useful

gcarreau commented 5 years ago

Not sure if people are still having problems with the folding/unfolding of nested list but I fixed it by passing the groups to a vis.DataSet using the solution provided in #32

if (opts.groups) {
            var groups = new vis.DataSet();
            opts.groups = fixNestedGroups(opts.groups);
            groups.add(opts.groups);
            timeline.setGroups(groups);
          }