search

daattali / timevis

📅 Create interactive timeline visualizations in R
http://daattali.com/shiny/timevis-demo/
Other
655 stars 157 forks source link

Fix folding #71

Closed strazto closed 5 years ago

strazto commented 5 years ago

Sorry I was trying to make a PR with my fork

daattali commented 5 years ago

I see you closed the previous one. I'm not sure what you're up to, but as long as there's one PR at the end of it all :)

Hopefully you had better luck with timevis maintainers to get some fixes!

strazto commented 5 years ago

Sorry dean, PRs base on your repo by default and I forget to change them to my fork when I make them.

Also, one of the reasons I closed it was because I am now one of the timevis maintainers as I had to dig into their repo & fix the folding myself, but did notice that what I'd written for dataframe_to_D3 is misbehaving a bit for groups that don't nest, and passing in an empty list-col (Which actually behaves works okay, but it makes them style like a nesting group)