daattali / timevis

📅 Create interactive timeline visualizations in R
http://daattali.com/shiny/timevis-demo/
Other
652 stars 157 forks source link

don't accept NA #85

Closed nfultz closed 4 years ago

daattali commented 4 years ago

Could you show me an example of when this becomes an issue?

nfultz commented 4 years ago

Apparently when showZoom = NA, the buttons are hidden as if showZoom = FALSE - I had written some sloppy logic, showZoom = max(df$end) - min(df$start) > ddays(7) to conditionally hide it, which did not work the way I thought it would. An error or warning would have helped a little.

daattali commented 4 years ago

Makes sense, thanks!