search

daattali / timevis

📅 Create interactive timeline visualizations in R
http://daattali.com/shiny/timevis-demo/
Other
652 stars 157 forks source link

saveWidget(selfcontained=TRUE) renders the zoom menu in <pre> tags #87

Closed rfaelens closed 4 years ago

rfaelens commented 4 years ago

Because of this, the following code fails, and setup of the timevis is not completed correctly: https://github.com/daattali/timevis/blob/e354debbef257801e8a2b07930f7f7daabc4dc6a/inst/htmlwidgets/timevis.js#L33

A quick workaround would be to test the presence of the zoom menu, and only register these listeners if the menu exists.

daattali commented 4 years ago

This seems to me like a bug in htmlwidgets::saveWidget(), would you agree? If so, we should file this bug with htmlwidgets

rfaelens commented 4 years ago

OK, will file the bug with htmlwidgets

daattali commented 4 years ago

Please link to this issue, thanks!

On Tue, Dec 3, 2019, 03:45 rfaelens <notifications@github.com wrote:

OK, will file the bug with htmlwidgets

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/daattali/timevis/issues/87?email_source=notifications&email_token=AAHIQFHII57VMV2ADTU7OTDQWYMEFA5CNFSM4JRLIVSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYR63I#issuecomment-561061741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHIQFD3A4PT7EYS5QQWNCLQWYMEFANCNFSM4JRLIVSA .