Open Tofull opened 2 years ago
Was wondering if the downcast propagation should be done on a copy of the points dataframe instead of the points dataframe itself.
If true, we should add points = points.copy()
at the beginning of pyntcloud.io.ply.write_ply
function.
Description
.ply
files were not written with "double" coordinates even though the xyz coordinates columns were in float64 format. I was dealing with ply files in geospatial context and required to save a.ply
file. I hit this issue, so here is the PR.This seems to have been a pain for the community:
Proposed changes
make float64 compatible with ply files (written ply files with float64 (double) coordinates can be opened by cloudcompare)
make property_format mapping better (written ply files can now exploit all the scalar data types a .ply file can support)
try downcasting column if column dtype is not compatible with PLY specification
fix most of flake8 issues (1 remaining)
backward compatible with https://github.com/daavoo/pyntcloud/issues/309
References :