search

dabapps / django-log-request-id

Django middleware and log filter to attach a unique ID to every log message generated as part of a request
BSD 2-Clause "Simplified" License
371 stars 64 forks source link

1.5.0 break the compatibility #41

Closed zcong closed 2 years ago

zcong commented 4 years ago

I got this error for the new version of log-request-id from log_request_id import local, NO_REQUEST_ID, OUTGOING_REQUEST_ID_HEADER_SETTING ImportError: cannot import name NO_REQUEST_ID

j4mie commented 4 years ago

Hi, thanks for letting us know about this.

Trying to understand your use case here - why are you importing that constant in your code?

We could just add a backwards compatibility shim so that will still work, but I wasn't expecting that would be something that users of the package would import themselves.