quickfix - Githubissues

dabapps / django-log-request-id

Django middleware and log filter to attach a unique ID to every log message generated as part of a request

BSD 2-Clause "Simplified" License

371 stars 64 forks source link

quickfix #56

Closed painassasin closed 3 years ago

painassasin commented 3 years ago

user_attribute must be a string, to use in in getattr
_generate_id have to be static method
more correct to use a suppress instead of try/except

j4mie commented 3 years ago

I'm not sure I understand the purpose or motivation behind these changes, and "quickfix" isn't a great title for a PR. I'm going to close this for now, thanks anyway!