search

dabapps / django-readers

A lightweight function-oriented toolkit for better organisation of business logic and efficient selection and projection of data in Django projects.
https://www.django-readers.org
BSD 2-Clause "Simplified" License
183 stars 7 forks source link

Update README.md by hardcode branch as main #63

Closed simkimsia closed 2 years ago

simkimsia commented 2 years ago

related to #61

this is a temporary fix in my opinion.

i prefer making this flexible per branch. See my comment about using pre-commit https://github.com/dabapps/django-readers/issues/61#issuecomment-1172455031 to make the it flexible per branch

j4mie commented 2 years ago

@simkimsia if you merge main back into your branch it should fix the build errors. Let me know if you don't have time and I'm happy to do it.

simkimsia commented 2 years ago

Oh Pls do

I'm on the phone now and stopped work for the day

It's like 1135pm now and I'm gonna walk the dog 🐶

I respect your decision not to use precommit

Can I ask if you can elaborate why you don't like ?

Not necessary just curious to hear contrary opinion. I saw other people use it. I don't. Cause it looks complicated n I got scared.

If you don't feel free to be honest publicly we can dm somewhere or exchange email

j4mie commented 2 years ago

Cause it looks complicated n I got scared.

Basically the same 😆

As I understand it, pre-commit involves using git hooks to have contributors (developers) run code on their machines before or after doing things. This seems unreliable and a bit odd to me.