`Aliased` and `Filtered` got broken in release 0.6 and have no unit test coverage

dabapps / django-rest-framework-serialization-spec

DEPRECATED, see https://github.com/dabapps/django-readers instead

MIT License

11 stars 0 forks source link

`Aliased` and `Filtered` got broken in release 0.6 and have no unit test coverage #64

Closed pmg103 closed 3 years ago

pmg103 commented 3 years ago

The changes made to the expand_nested_specs code seems to be the culprit as it doesnt handle the Filtered type any more https://github.com/dabapps/django-rest-framework-serialization-spec/compare/v0.5-beta...v0.6-beta#diff-7490d97e15430637e9534f8001afa093a6c2f1ff86f5a814f906c58b9d224057R222-R232

First, should be covered by unit tests so that we would have known immediately it was broken!

pmg103 commented 3 years ago

We should probably ensure coverage is 100%:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
serialization_spec/plugins.py            46     14    70%
serialization_spec/serialization.py     170      8    95%
serialization_spec/utils.py               5      4    20%
---------------------------------------------------------
TOTAL                                   221     26    88%