search

dabapps / roe

DabApps' Project Development Kit
https://dabapps.github.io/roe
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Checkboxes are round but should be square #327

Closed alpower closed 3 years ago

alpower commented 5 years ago

Seems like checkboxes are round out of the box from Roe. They should definitely be square - its what people are used to!

image

JakeSidSmith commented 5 years ago

Where are you seeing this?

Pictured below: a radio and checkbox next to eachother.

Screen Shot 2019-10-18 at 14 36 47
alpower commented 5 years ago

In Raileasy

https://github.com/dabapps/roe/blob/e1e32b4a87ac920778e8075cf40cac25d9df6f3d/src/less/overrides.less#L189

I'd set @border-radius-base to 8px to make inputs and buttons a certain roundness, and this is inherited from the line above. IMO they should be hardcoded in Roe or based on their own var.

I think I will reset the base var back to what it was, and then do custom var for buttons and input.

JakeSidSmith commented 5 years ago

Defo worth another variable for that (but based on the base radius).