search

dabbott / javascript-playgrounds

An interactive JavaScript sandbox
https://unpkg.com/javascript-playgrounds/public/index.html
Other
1.4k stars 131 forks source link

How to show tablet device? #14

Closed vysakh0 closed 7 years ago

vysakh0 commented 8 years ago

I wanted to see the output for a tablet. So, I tried changing the width(in the url) as given in the docs to "//cdn.rawgit.com/dabbott/react-native-web-player/gh-v1.2.4/index.html#width=768&device=android"

But it doesn't produce tablet like device, more like a bigger phone result. https://output.jsbin.com/veyomoleha Wondering how to go about it. Thanks for the project, would appreciate any help.

dabbott commented 8 years ago

I didn't add any tablet images, but happy to accept a PR.

Phone images and sizes are shamelessly ripped from the (MIT licensed) library Framer.js: https://github.com/koenbok/Framer/blob/master/framer/Components/DeviceComponent.coffee

And you can add them here in the web player code: https://github.com/dabbott/react-native-web-player/blob/master/constants/Phones.js

dabbott commented 7 years ago

Closing, as I haven't seen any other interest for tablet images. Still happy to accept a PR though.

merbin2012 commented 6 years ago

@dabbott How can I remove the image, I want to show the output without any image frame. Just I want to show plain output.