search

dabbott / javascript-playgrounds

An interactive JavaScript sandbox
https://unpkg.com/javascript-playgrounds/public/index.html
Other
1.4k stars 131 forks source link

Update react-native-web to 0.0.73 #20

Closed AlanFoster closed 6 years ago

AlanFoster commented 7 years ago

I would like to have access to Button for a react-native presentation, which is available when bumping the react-native-web version.

Let me know if there's anything else missing as part of this PR :+1:

AlanFoster commented 7 years ago

When playing around with this, it seems possible to trigger the following error:

TypeError: Cannot read property 'getHostNode' of null
Show Details

I'm not sure if this is related to the version bump or not. The reproduction steps are currently unclear, but it breaks whilst progressively editing code - and a page refresh fixes the issue.

dabbott commented 7 years ago

Hmmm, I'm not sure either.

I think you'll want to upgrade react and react-dom to whatever version react-native-web@0.0.73 uses (15.4.1?)

Also I would remove the ^ from ^0.0.73 to lock down the version, in case people install via npm. Patch versions aren't really patch versions here, since they contain API changes and other potentially breaking things.

After you update, I can play around with it too and try to figure out what's going on.

morenogiudici commented 7 years ago

I just updated the package.json file: "react": "~15.4.1", "react-dom": "~15.4.1", "react-native-web": "^0.0.94", and everything seems to work

necolas commented 7 years ago

👍 latest versions are now react(-dom)@15.5 and react-native-web@0.0.97

dabbott commented 6 years ago

Versions have been updated:

"react": "^16.2.0"
"react-dom": "^16.2.0"
"react-native-web": "0.5.3"