dabeaz / curio

Good Curio!
Other
4.02k stars 241 forks source link

`ActivationBase` usage in kernel.py L611 - where is it defined? #255

Closed acushner-xaxis closed 6 years ago

acushner-xaxis commented 6 years ago

hi, i was reading through the curio code and i came across this line:

_activations = [ act() if (isinstance(act, type) and issubclass(act, ActivationBase)) else act
                 for act in kernel._activations ]

and i can't seem to find where ActivationBase is defined:

xaxis@tusebook_pro ~/virtualenvs/current$ grep -ilr ActivationBase *
lib/python3.6/site-packages/curio/kernel.py
lib/python3.6/site-packages/curio/__pycache__/kernel.cpython-36.pyc
xaxis@tusebook_pro ~/virtualenvs/current$

did you mean Activation from activation.py instead?

the only way i can see this working is if you only ever get instances, not types.

thanks, adam

dabeaz commented 6 years ago

This is quite clearly a brain-fart on my part. Yes, it should be 'Activation'. I'll push a patch. Thanks for the eagle-eyes!

acushner-xaxis commented 6 years ago

thank you, love your talks, love the project. really cool stuff. can't wait to start using it for real.