search

dabeaz / curio

Good Curio!
Other
4.01k stars 240 forks source link

Add custom marker for tests that require internet #320

Closed carlwgeorge closed 4 years ago

carlwgeorge commented 4 years ago

Hello! I'm the maintainer of the python-curio RPM package in Fedora. I was working on updating it to your latest version, but the test suite did not pass. After some troubleshooting I realized that 96ed9c5375ef6c24b373870f757994268cae36a8 adds tests that make outgoing network connections. The Fedora build system does not permit this for their package builds. Would you consider adding a custom marker to make it easier to skip tests that require internet connectivity? I have implemented this in my fork, modeled after a pytest example. I was preparing to send a pull request before I noticed that your contributing guidelines state pull requests are invite only. What do you think?

dabeaz commented 4 years ago

I'm ok with a PR for this. If there is anything that can be done to fix the test, that's good too.

carlwgeorge commented 4 years ago

Awesome. I've opened #321.

If I'm reading this code right, I imagine "fixing" them would require having something listen on localhost port 25000 and 443 with TLS. I'm not sure how something like that would be implemented, but for now just making these type of tests easily skippable is good enough for me.