search

dabeng / OrgChart

It's a simple and direct organization chart plugin. Anytime you want a tree-like chart, you can turn to OrgChart.
MIT License
2.83k stars 767 forks source link

Regression: Drag and Drop is not functional in the demo page #712

Open jxmai opened 1 year ago

jxmai commented 1 year ago

Regression description: The drag and drop feature is not functional in the latest version

Ways to replicate: Go to https://dabeng.github.io/OrgChart/drag-drop.html, and try to drag and drop any node.

Expected behavior: Drag and drop feature should be working

Actual behavior: Drag and drop isn't working

Impact: This is crucial regression as drag and drop feature is widely used.

jxmai commented 1 year ago

@dabeng Could you please verify the regression whenever you have a chance? If drag and drop feature is broken in orgchart, it should have board impact of the usability of this component. Thanks!

jxmai commented 1 year ago

Link to: https://github.com/primefaces-extensions/primefaces-extensions/issues/1182

jxmai commented 10 months ago

The github demo missed https://www.npmjs.com/package/json-digger dependency.

In the demo, https://dabeng.github.io/OrgChart/drag-drop.html

There's nojson-digger.js

image

image

However, when running the demo on local, http://localhost:3000/drag-drop.html, json-digger.js.

image

image

jxmai commented 10 months ago

@dabeng After https://github.com/dabeng/OrgChart/commit/28f797a9f2ae77896ce387d9c6de144e2cea4226#diff-24a5fef88d585add1c01eb9b69b37c6875761e6088fdfc7ace2035c2e3377e9dR1123-R1134, the Orgchart lib can only run on NodeJS specific environment because of the following dependency: js/json-digger.js. Previously jquery Orgchart is highly portable to any environment.