search

daboross / fern

Simple, efficient logging for Rust
MIT License
848 stars 51 forks source link

Add feature for syslog5 #65

Closed Cogitri closed 2 years ago

Cogitri commented 4 years ago

fixes #47

Tested this on a project of mine and changing it was as easy as changing the version

daboross commented 4 years ago

Hi - thank you for doing this! I'm afraid actually updating it needs to be a bit more complicated, though.

If we just remove support for syslog version 4, that means anyone currently depending on fern and syslog v4.0 would have their build broken. And thus to keep compatibility guarantees, we'd need to release a new major version of fern. Since it's just a dependency update, I'd rather not do that.

So, to keep it compatible, we'll need to keep both syslog-4 and syslog-5 features concurrently. I'd be happy to remove syslog-4 support in the next major version release, but that should wait until fern actually has breaking changes to make itself.

Cogitri commented 4 years ago

Oh fair, I didn't consider that that'd require a minor version bump. I'll try to look into fixing this in the next week or so, thanks for taking a look

Cogitri commented 4 years ago

I've re-added the syslog4 feature.

BTW, now that https://github.com/Geal/rust-syslog/issues/41 is fixed in syslog v5, do we to do something additional in fern to avoid allocations?

Cogitri commented 4 years ago

Hm, the --all-features test run fails on travis because syslog-4 and syslog-5 have some duplicate definitions, not sure how we best handle that

Roguelazer commented 3 years ago

Any way we can help move this forward? I would very much like this feature.

Roguelazer commented 3 years ago

bump

Roguelazer commented 2 years ago

I added syslog 6 support in #91

Cogitri commented 2 years ago

Sure, let me close this