search

daboross / fern

Simple, efficient logging for Rust
MIT License
848 stars 51 forks source link

Reopen 1 #68

Closed vorner closed 2 years ago

vorner commented 4 years ago

This is for #66. Also, it is supported on windows now (though the list of usable signals is quite small and one would prefer reopening by the handle manually there probably).

But I'm not entirely happy about it, to be honest. The fact reopen-0.3 already used all the reopen functions and Reopen variants, and the stable version now has to use reopen1 seems a bit inelegant. Any suggestions?

vorner commented 4 years ago

I'll look into the build errors.

vorner commented 4 years ago

The travis build failures seem to be unrelated. The object dependency is failing to compile (needs a newer version of rustc), which is depended on by syslog 4 (transitively, through backtrace).

daboross commented 2 years ago

Sorry I haven't responded to this for 1.5 years! Especially as I offered that I'd be willing to accept a PR, then completely ignored it.

Agreed that the CI changes seem unrelated.

I've just merged another PR which created a merge conflict here, so I'm going to merge this manually.

daboross commented 2 years ago

And thanks for making this PR! I did and do appreciate it.

Apologies again for letting it just sit here.