daboross / fern

Simple, efficient logging for Rust
MIT License
835 stars 50 forks source link

add support for syslog 6 to fern #91

Closed Roguelazer closed 2 years ago

Roguelazer commented 2 years ago

See #47

I did this in a way that keeps all syslog-3 and syslog-4 functionality intact.

BlackDex commented 2 years ago

@daboross it would be really great if this could be merged. This would allow everybody who is using fern together with syslog to get rid of the insecure time crate version!

BlackDex commented 2 years ago

May i suggest that you also update the chrono dependency to omit the oldtime feature?

So instead of:

chrono = { version = "0.4", optional = true }

Use

chrono = { version = "0.4", default-features = false, features = ["clock"], optional = true }

That way the old version of the time crate would be fully gone when using syslog6 :tada:

( And after that we only need to hope it gets merged :crossed_fingers: )

daboross commented 2 years ago

Thank you for this! This looks great. Sorry to let a good PR sit without a review or merge for so long!