search

dabreegster / odjitter

Disaggregate zone-based origin/destination data to specific points
Apache License 2.0
12 stars 6 forks source link

Sanit checking of weighted results #18

Open Robinlovelace opened 2 years ago

Robinlovelace commented 2 years ago

There are some statistical sanity checks in #7 but I've just done some more sanity checks and the results are good. Summary of them below. Three schools in one zone:

image

With weights, how many trips have destinations at each?

Strong near-linear positive relationship between n_trips and weight:

image

Robinlovelace commented 2 years ago

Without weights there is no correlation. Weights work!

image

dabreegster commented 2 years ago

Awesome, thanks! I wonder if we could check in your tests to prevent future regressions? If it's not a self contained r script, no worries

On Wed, Feb 9, 2022, 7:29 PM Robin @.***> wrote:

Closed #18 https://github.com/dabreegster/odjitter/issues/18.

— Reply to this email directly, view it on GitHub https://github.com/dabreegster/odjitter/issues/18#event-6036839460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWLF72TCJ4LU6U6PABC4DU2K6C5ANCNFSM5N6NZGNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Robinlovelace commented 2 years ago

I could do that but would take some time. Reopening to track progress, note: I may be able to get it to general principle stage and can provide more example input data if that would be useful?

dabreegster commented 2 years ago

Not a priority at all. I should really find better techniques for unit testing in Rust; I'll think about doing that without depending on so many test data files checked in