search

dabreegster / route_snapper

Draw routes in MapLibre snapped to a street network using client-side routing
https://dabreegster.github.io/route_snapper
Apache License 2.0
147 stars 9 forks source link

Jittery snapping sometimes #20

Closed dabreegster closed 1 year ago

dabreegster commented 1 year ago

https://user-images.githubusercontent.com/1664407/211030226-f2c855b0-cb55-461a-bf98-4e990ac52162.mov

Repro near the Lea bridge in Hackney: https://acteng.github.io/atip/scheme.html?authority=Hackney#18.6/51.5620442/-0.0459354 I've hit this elsewhere too.

Ideas: visualize the circle around the cursor, and the circles we snap to. Make sure we're not snapping so eagerly when zoomed in like this?

dabreegster commented 1 year ago

Aha, this is silly. The red circle tracks the mouse just fine and is a fine size:

https://user-images.githubusercontent.com/1664407/211032759-4e029ed7-081b-4881-9457-6e4e469cc643.mp4

But we're snapping to gigantic blue circles centered at every node, with a fixed size: Screenshot from 2023-01-06 14-31-19

The snapping finds the closest point on the perimeter of any circle, not the center. I even have a TODO about not doing this!

dabreegster commented 1 year ago

Decided to make a change here... just snap to the nearest neighbor period, even if it's beyond some threshold. It feels more natural to me. Before:

https://user-images.githubusercontent.com/1664407/211040887-434c8db9-0071-4753-9034-2c5a145d1b01.mp4

After:

https://user-images.githubusercontent.com/1664407/211040904-c213924d-10da-4853-a76c-3d99a4b8035d.mp4