search

dabroek / node-cache-manager-ioredis

Redis store for node-cache-manager using IORedis.
MIT License
59 stars 29 forks source link

Upgrade to ioredis 5 #32

Open phoenix741 opened 2 years ago

phoenix741 commented 2 years ago

Hi,

Can you upgrade to ioredis 5.* ?

Thanks

kenzik commented 2 years ago

Can you describe what issues you have encountered using this package out of the box and/or why specifically you are looking for support for ioredis 5.* ?

From what I understand this just uses get/set, so I'm curious as to your situation.

phoenix741 commented 2 years ago

In our project team we have the policy to update libraries (and nodejs) to latest version to ensure to be always up to date, have all corrections, and vulnerabilities fixes.

More, in a project that depends of ioredis and "node-cache-manager-ioredis" having two version of ioredis increase the bundle by having two version of a library server side (ie: when using lambda).

ioredis 4.* is already 6 months old.

We don't encounter issue at today.

Tirke commented 2 years ago

Hi @phoenix741 Did a rewrite of this package with ioredis@latest here: https://www.npmjs.com/package/@tirke/node-cache-manager-ioredis

schmod commented 1 year ago

personally, I'd just remove the direct dependency on ioredis and make the External Redis Instance configuration pattern mandatory.

It makes dependency-management far simpler, and at worse, only adds about 2 extra lines of code.