dacap / keyfreq

Track Emacs commands frequency
320 stars 25 forks source link

Added M-x tracking of commands issued. #3

Closed mattfidler closed 10 years ago

mattfidler commented 11 years ago

David,

I think it would be useful to track the M-x commands issued as well. This patch adds this capability.

Matt.

dacap commented 11 years ago

Hi Matthew, I've tested it and it seems that it's counting two times M-x commands. E.g. close Emacs, delete ~/.emacs.keyfreq, start Emacs, execute M-x eshell, see the key frequencies and you will see eshell two times.

mattfidler commented 11 years ago

Should fix the duplicate counts of eshell. Don't think it covers the case M-x eshell M-x eshell. I believe it only counts that sequence once. On Jun 13, 2013 1:38 PM, "David Capello" notifications@github.com wrote:

Hi Matthew, I've tested it and it seems that it's counting two times M-x commands. E.g. close Emacs, delete ~/.emacs.keyfreq, start Emacs, execute M-x eshell, see the key frequencies and you will see eshell two times.

— Reply to this email directly or view it on GitHubhttps://github.com/dacap/keyfreq/pull/3#issuecomment-19414734 .

dacap commented 11 years ago

It's still happening.

mattfidler commented 11 years ago

I'll have to look into it next week. When I use helms M-x replacement it only counts it once. Do you use smex, ido ubiquitous or jusr plain M-x? On Jun 14, 2013 2:26 PM, "David Capello" notifications@github.com wrote:

It's still happening.

— Reply to this email directly or view it on GitHubhttps://github.com/dacap/keyfreq/pull/3#issuecomment-19476697 .

dacap commented 11 years ago

Plain M-x, maybe it's related to eshell specifically, I'll test it later

mattfidler commented 11 years ago

I checked to see by looking at the „major mode„ bindings. Maybe kwyfreq is already counting M-x commands, but not cokmands issued from smex and the like. On Jun 14, 2013 2:51 PM, "David Capello" notifications@github.com wrote:

Plain M-x, maybe it's related to eshell specifically, I'll test it later

— Reply to this email directly or view it on GitHubhttps://github.com/dacap/keyfreq/pull/3#issuecomment-19478009 .

mattfidler commented 10 years ago

I think this was fixed by a more recent helm.