dacap / keyfreq

Track Emacs commands frequency
320 stars 25 forks source link

Symbol's function definition is void: reduce #9

Closed knowhy closed 10 years ago

knowhy commented 10 years ago

keyfreq-show returned:

let*: Symbol's function definition is void: reduce

I could fix this either by adding (require 'cl) or by changing reduce to cl-reduce in keyfreq-format-list

knowhy commented 10 years ago

(if (featurep 'cl-lib) (require 'cl-lib) (require 'cl))

seems to be the problem. reduce is provided by cl.el but it is only loaded if cl-lib is not present on the system.

srustamo commented 10 years ago

getting the same error. @knowhy do I need to install cl-lib package? using v 24.3.1. cl-lib 1 is built-in. also, installing cl-lib 0.5 from melpa fixes the issue. what gives?

knowhy commented 10 years ago

yes, I think so. reduce is a common lisp function. But you can also google for it and just implement the reduce function yourself.

2014-03-19 7:21 GMT+01:00 srustamo notifications@github.com:

getting the same error. @knowhy https://github.com/knowhy do I need to install cl-lib package? using v 24.3.1

Reply to this email directly or view it on GitHubhttps://github.com/dacap/keyfreq/issues/9#issuecomment-38021262 .

Henrik Tillmann Pingel

Reuterstraße 82 12053 BERLIN

0160-4875684

e-mail: pingelhe@gmail.com

dacap commented 10 years ago

This was fixed in 7035d6d631f6bffdcf4bb972b6d3ce8059258fe9

gzc9047 commented 10 years ago

https://github.com/dacap/keyfreq/commit/7035d6d631f6bffdcf4bb972b6d3ce8059258fe9 don't work on my mac os. Manually using cl instead of cl-lib it works fine. Environment: emacs: 24.3.1 installed by port. Both cl and cl-lib are installed in /opt/local/share/emacs/24.3/lisp/emacs-lisp/