daccotta-org / daccotta

A social network for movies.
https://app.daccotta.com
MIT License
84 stars 42 forks source link

BUG -> Password length showing in login #182

Closed Gauravtb2253 closed 1 month ago

Gauravtb2253 commented 1 month ago

Hello In the login form when the error message of password is shown it is displaying minimum 6 length characters But for the login such message must not be shown for security reasons I would like to solve this issue

image

github-actions[bot] commented 1 month ago

👋 Thank you @Gauravtb2253 for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!

sid0000007 commented 1 month ago

@Gauravtb2253 This issue is not a bug, we want the user to see the password contraints so that they can modify the new password that is valid for our portal. Correct me if I got you wrong.

Gauravtb2253 commented 1 month ago

Yes but the constraint must be shown while creating a new user and not login

Like if someone is trying to access other persons account he will get to know that password is of x length which is not good for security reasons

sid0000007 commented 1 month ago

Yes but the constraint must be shown while creating a new user and not login

Like if someone is trying to access other persons account he will get to know that password is of x length which is not good for security reasons

got you @Gauravtb2253 Go ahead. Please remove the visiblity of the contrainst on the login page.

sid0000007 commented 1 month ago

@Gauravtb2253 Working or not?

Gauravtb2253 commented 1 month ago

actually I created a PR few days back but it got closed

Gauravtb2253 commented 1 month ago

should I make new PR