search

dachad / tcpgoon

tcpgoon, maximum TCP connections tester
MIT License
193 stars 21 forks source link

Issue-1_DCR-214 - Pretty output and debug mode for extra information in stderror #12

Closed dcaba closed 6 years ago

dcaba commented 6 years ago

Now we are no longer tracking in the standard output what we are doing... this is only staff for the new debug flag. And we use gochannels to communicate status of the connections, and an in memory slice to track the status of each. These connections do have an struct that describes their status, and allows pretty printing.

Some refactor could be possible / moving the reporting functions outside of the function raising execution threads, that could be also running in a different thread.

dcaba commented 6 years ago

this covers https://github.com/dachad/check-max-tcp-connections/issues/1

dcaba commented 6 years ago

@chadell , latest comments introduced, plus final code reallocation to leave this as clean as possible. Final review required

chadell commented 6 years ago

wow! it looks much cleaner now! fantastic work @dcaba ! Just fix the CI 😉

dcaba commented 6 years ago

codacy picked a couple of documentation issues (now fixed)... not sure why travis is failing (we havent change anything related to travis, and the error looks quite generic... :thinking: )

dcaba commented 6 years ago

@chadell , builds now passed (looks there was a problem with travis; no actual changes, just re-running the builds). Can you mark this as reviewed?