search

dachad / tcpgoon

tcpgoon, maximum TCP connections tester
MIT License
193 stars 21 forks source link

Add unit testing to all methods #15

Closed chadell closed 4 years ago

chadell commented 6 years ago
chadell commented 6 years ago

27 covering tcpconnect package

dcaba commented 6 years ago

Proposal: @dcaba is taking care of end to end tests (close to the dockerization we have been discussing), plus mtcpclient? @chadell takes care of tcpclient, cmdutil and review of tcpserver?

chadell commented 6 years ago

yup 👍

dcaba commented 6 years ago

btw, I've detected random errors because of concurrent map writes when executing our current "functional test":

=== RUN   TestTcpConnect
127.0.0.1:37748
127.0.0.1:37746
fatal error: concurrent map writes

TO bear in mind when refactoring tests...

chadell commented 6 years ago

tcpclient done in #27

dcaba commented 4 years ago

We are promoting end to end tests implementation in parallel, and we will add testing coverage incrementally, as part of the next PRs we are going to raise