Per connection metrics - Githubissues

dachad / tcpgoon

tcpgoon, maximum TCP connections tester

MIT License

193 stars 21 forks source link

Per connection metrics #23

Closed chadell closed 6 years ago

chadell commented 6 years ago

Print spent time to get a connection established in debug mode
Print a report of TCP established times at the end of execution

dcaba commented 6 years ago

I'll need to hit you hard in this one :) . Suggestions in regards how to encapsulate logic soon ;)

chadell commented 6 years ago

@dcaba I hope that now it looks better :) I've took into account your points (great ones btw), and you will see that most of them have been implemented. I would highlight two points:

I've differentiate established vs errored tcp duration, so we print specific output for each one, and also tested it on partial unsuccessful execution
I've consolidate all []tcpclient.connection to GroupOfConnection and also same methods that I understand that are more related to the GroupOfConnections than to the Connection or ConnectionStatus. Please, have a look and tell me your point.

dcaba commented 6 years ago

For me, the PR can be merged. There's some final comments, in regards wording, and if we actually need to have two members in the connectionMetrics struct as this stage, just one, or start having different structs (but a common interface) depending on the path the connection followed... But this is more a thought than something we really need to care right now. Good job, Christian! Hope you enjoyed this development and you found useful the comments and changes!

chadell commented 6 years ago

@dcaba could you review the PR again? my last commit dismissed your previous one