Issue18 - Publishing updated docker image on merge-to-master

dachad / tcpgoon

tcpgoon, maximum TCP connections tester

MIT License

193 stars 21 forks source link

Issue18 - Publishing updated docker image on merge-to-master #35

Closed dcaba closed 6 years ago

dcaba commented 6 years ago

Plus script to emulate the behavior we expect travis does continuously. Feedback would be appreciated (it took me very long efforts, especially because of travis-docker images are ugly :( )

dcaba commented 6 years ago

See also the updated project description in docker hub: https://hub.docker.com/r/dachad/tcpgoon/

dcaba commented 6 years ago

This should cover https://github.com/dachad/tcpgoon/issues/18 completetly

chadell commented 6 years ago

i've done a first reading and just small comments, nothing blocking from my side but I will do a new review to test the scripts and get deep into the bash scripts Note: The history of commits makes it a bit difficult to follow

dcaba commented 6 years ago

Comments replied. Found one minor bug while testing some of the checks you were mentioning. New commit added. And... why do you care so much of the history behind this branch? I will squash+merge when this is integrated into master, and I don't know why you look at previous commits :( (imho, just review the latest version of the diff/PR)