search

dachad / tcpgoon

tcpgoon, maximum TCP connections tester
MIT License
193 stars 21 forks source link

Issue15 - Testing mtcpclient part1 (stddev function) #44

Closed dcaba closed 6 years ago

dcaba commented 6 years ago

First commit with a minimum contribution to the unit tests: https://github.com/dachad/tcpgoon/issues/15

Applying TDT for the stddev calculations. Some minor changes/additions introduced in the tested code, but some others expected (see TODO) once we actually increase coverage.

Added the race flag to our scripted go test execution.

As usual, I will squash and merge once approved

chadell commented 6 years ago

@dcaba , do you want to merge this PR as a first step on mtcpconnection testing? or are you expecting to add more commits to it? (just to understand if you are waiting for my approve)

dcaba commented 6 years ago

Hi,

I'd merge to keep prs as small as possible, and benefit from them soon ;)

On Dec 11, 2017 08:06, "Christian Adell" notifications@github.com wrote:

@dcaba https://github.com/dcaba , do you want to merge this PR as a first step on mtcpconnection testing? or are you expecting to add more commits to it? (just to understand if you are waiting for my approve)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dachad/tcpgoon/pull/44#issuecomment-350639013, or mute the thread https://github.com/notifications/unsubscribe-auth/APKZPqN22FbJv_-hPMRVaEGSIK3pKTZ1ks5s_NR6gaJpZM4Q71Wx .