search

dachcom-digital / pimcore-formbuilder

Pimcore Formbuilder - create forms easily!
Other
92 stars 47 forks source link

E-Mail Editor not editable #447

Closed PSC-techsigns closed 5 months ago

PSC-techsigns commented 5 months ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Hi there,

we have two different Pimcore (11.2.3) projects both using the Formbuilder 5.0.6 For both Projects its not possible to edit anything inside the tinyMCE and the buttons beside the code and table are disabled image also dropping the Fields into the editor does nothing. the table button also dosnt work, the only thing that does something is the code button, inside of it its even possible to add/write stuff that gets moved into the content of the editor but that's not really helpfull for my customer.

With a bit of tinkering around i found out that inside of /public/js/extjs/extensions/formMailEditor.js application/vendor/dachcom-digital/formbuilder/public/js/extjs/extensions/formMailEditor.js Row 334 switching editable_root: false, to true is solving the issue, making the editor editable again but i am not aware if this causes any unforeseen issues later down the line or for what reason this option is set to false currently. In a Test, a test from did sent the email correctly in an edited state and i didnt see any other issues so far.

correct me if i'm wrong but as i don't see any option i would need to set i would say this is currently a bug in the Formbuilder?

solverat commented 5 months ago

Hey @PSC-techsigns, thanks for your investigation. That's definitely a bug!

Our goal was to disable the root editing (only allow editing inside a table) to keep the structure clean. But I don't see any real benefits (besides, that it's not working :) ) and adding extra content also works - so, the solution is simple and like you suggested: removing the editable_root document.