search

dachcom-digital / pimcore-members

Pimcore Object, Asset and Document Restriction & Frontend Authentication
Other
54 stars 34 forks source link

members checks for duplicates in combination with cmf, on set cmf checkbox "active" and save #99

Closed lilsmada closed 5 years ago

lilsmada commented 5 years ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Bildschirmfoto 2019-06-09 um 09 03 00

Hey,

I have something not so desired, it´s not really a bug, but could lead to problems. If set a customer (member) active (checkbox „active“ , checkbox comes with cmf-bundle -> customer class), and save the customer, the members bundle checks for duplicates with firstname AND lastname.

However, it is possible that customers (members) with the same first and last name exist!?

br

solverat commented 5 years ago

@tobbert: MembersBundle does not apply any checks against duplicates. This comes straight from the CMF:

https://github.com/pimcore/customer-data-framework/blob/24eedba5da2bccc50e12b26e08d8e437a7483790/src/CustomerSaveValidator/DefaultCustomerSaveValidator.php#L100-L119

lilsmada commented 5 years ago

Hello,

thanks, I got it.

br

Am 22.07.2019 um 14:26 schrieb Stefan Hagspiel notifications@github.com:

@tobbert https://github.com/tobbert: MembersBundle does not apply any checks against duplicates. This comes straight from the CMF:

https://github.com/pimcore/customer-data-framework/blob/24eedba5da2bccc50e12b26e08d8e437a7483790/src/CustomerSaveValidator/DefaultCustomerSaveValidator.php#L100-L119 https://github.com/pimcore/customer-data-framework/blob/24eedba5da2bccc50e12b26e08d8e437a7483790/src/CustomerSaveValidator/DefaultCustomerSaveValidator.php#L100-L119 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dachcom-digital/pimcore-members/issues/99?email_source=notifications&email_token=AJMMYUKJCMFGL4GKNT2ATETQAWRQPA5CNFSM4HWI2KFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2PYETA#issuecomment-513770060, or mute the thread https://github.com/notifications/unsubscribe-auth/AJMMYUJSYXYHKKDWW64N4U3QAWRQPANCNFSM4HWI2KFA.