search

dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
36 stars 14 forks source link

Document\Page title property #12

Closed dpfaffenbauer closed 4 years ago

dpfaffenbauer commented 4 years ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

SEO disables the default Pimcore title and description fields, but it doesn't set these fields on save anymore. thus if you use them, they cannot be changed.

solverat commented 4 years ago

I'm not sure what you mean. If you're going to install the seo bundle within a existing project with existing defautl title and descriptions, the SEO-Bundle will migrate them:

  1. Add a default title & description to a pimcore page: image

  2. Enable SEO-Bundle.

  3. Open the document in a frontend view, original title and description is still available: image

  4. Open the SEO-Tab, original title and descriptions are available: image

  5. Change those fields and finally the new data will be used.

dpfaffenbauer commented 4 years ago

What I mean is, that you don't set the original values anymore, so document->getTitle returns the old value or a null value, the same with description. Since these fields are pimcore default, SEO Bundle should also set them.

solverat commented 4 years ago

Right, adding title and description on a pre-update event should do the job!