search

dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
38 stars 14 forks source link

bug: duplicate tabs #28

Closed passioneight closed 1 year ago

passioneight commented 2 years ago

Actual behaviour

After installing & configuring the bundle, the SEO-tab contains duplicate tabs:

image

Expected behaviour

Every tab is displayed exactly once.

Steps to reproduce.

  1. Create Pimcore 10.4.4 instance
  2. Require, enable and install bundle
  3. Use 2 or more integrators (see below for an example)
  4. Create 1 document and open the SEO-tab
# Example config

seo:
    meta_data_configuration:
        meta_data_provider:
            auto_detect_documents: true
        meta_data_integrator:
            documents:
                enabled: true
                hide_pimcore_default_seo_panel: true
            enabled_integrator:
                -   integrator_name: title_description
                -   integrator_name: twitter_card
                    integrator_config:
                        twitter_image_thumbnail: 'socialThumb'

Additional info

I'm aware that the docs state 10.1-10.2 as supported versions, but this bundle was suggested by the Pimcore-Community, so, I figured it would still work.

solverat commented 1 year ago

Hey @passioneight. I'm not able to reproduce this on my installation. Is it possible that you've defined the enabled_integrator in more than one config file?

solverat commented 1 year ago

Ok, that's the issue here. You should not configure your enabled_integrator in multiple configuration files. I suggest creating a single file at config/packages/seo.yaml. However, i added a check, to avoid this issue.

See https://github.com/dachcom-digital/pimcore-seo/pull/40