search

dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
38 stars 14 forks source link

Does not use BundleManagerEvents #29

Closed dkarlovi closed 1 year ago

dkarlovi commented 2 years ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Currently, the best practice direction is to use BundleManagerEvents to configure the bundle, with old structure being obsolete. The bundle as-is currently doesn't listen to bundle manager events to register resources, relying instead on the old mechanism which no longer works in some cases.

solverat commented 1 year ago

@dkarlovi While this is correct when it comes to the app itself, a standalone bundle is still allowed to use the getCssPaths and getJsPaths methods, right? Am I missing something here?

If you're talking about this one: image

We're aware of that, SEO Bundle 2.2 is going to support Pimcore >= 10.5 only.