search

dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
38 stars 14 forks source link

add presets to html tag integrator #42

Closed solverat closed 1 year ago

solverat commented 1 year ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #37
aarongerig commented 1 year ago

@solverat Have you checked if the meta tags actually get printed in the HTML output? Just now I created the PR for V1 and tried to test the outcome in the HTML source code. Unfortunately the HeadMeta class always looses track of the raw HTML tags we are adding via the HTML Tag Integrator.

solverat commented 1 year ago

Yes. My Head:

<head>
    {% block metadata %}
        {{ pimcore_head_title() }}
        {{ pimcore_head_meta() }}
        {{ pimcore_head_link() }}
    {% endblock metadata %}
</head>
aarongerig commented 1 year ago

I have the exact same head and only the <meta name="description" content="..."> gets output. I guess there has to be a difference between Pimcore 6 and Pimcore 10 then. 🤔

PS: The HTML Tag Integrator without the preset feature also does not work in V1 / Pimcore 6.

solverat commented 1 year ago

Should also work for P6. Did that in about 5000 P6 projects! :)

So it would be nice to know if you've figured it out!