Closed aarongerig closed 1 year ago
@aarongerig Mhm, changing the HeadMeta Namespace would break Pimcore 6 Installation before v 6.9, right?
Proposal: Change this to 10.9:
Please add the missing upgrade note here, we're going to release Version 1.2 which only supports P 6.9, which should be ok: https://github.com/dachcom-digital/pimcore-seo/blob/1.x/UPGRADE.md:
@solverat Done!
@aarongerig Thanks, do you want to test the 1.x branch? Otherwise, I'm going to release the 1.2 right away.
@solverat Let me do that real quick, I'll confirm that it works here shortly.
@solverat Works great! You can release v1.2 if you'd like.
@aarongerig: done! https://github.com/dachcom-digital/pimcore-seo/releases/tag/v1.2.0
PR for V1 (See https://github.com/dachcom-digital/pimcore-seo/pull/42)
PS: The reason for my issue not rendering the tags was because the old implementation was referencing the deprecated
Pimcore\Templating\Helper\HeadMeta
andPimcore\Templating\Helper\HeadTitle
classes. Once I replaced them with the newerPimcore\Twig\Extension\Templating\HeadMeta
andPimcore\Twig\Extension\Templating\HeadTitle
it worked flawlessly. 😉