dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
38 stars 14 forks source link

[HtmlTagIntegrator] Add presets (V1) #43

Closed aarongerig closed 1 year ago

aarongerig commented 1 year ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

PR for V1 (See https://github.com/dachcom-digital/pimcore-seo/pull/42)

PS: The reason for my issue not rendering the tags was because the old implementation was referencing the deprecated Pimcore\Templating\Helper\HeadMeta and Pimcore\Templating\Helper\HeadTitle classes. Once I replaced them with the newer Pimcore\Twig\Extension\Templating\HeadMeta and Pimcore\Twig\Extension\Templating\HeadTitle it worked flawlessly. 😉

solverat commented 1 year ago

@aarongerig Mhm, changing the HeadMeta Namespace would break Pimcore 6 Installation before v 6.9, right?

solverat commented 1 year ago

Proposal: Change this to 10.9:

image

Please add the missing upgrade note here, we're going to release Version 1.2 which only supports P 6.9, which should be ok: https://github.com/dachcom-digital/pimcore-seo/blob/1.x/UPGRADE.md:

Version 1.2

aarongerig commented 1 year ago

@solverat Done!

solverat commented 1 year ago

@aarongerig Thanks, do you want to test the 1.x branch? Otherwise, I'm going to release the 1.2 right away.

aarongerig commented 1 year ago

@solverat Let me do that real quick, I'll confirm that it works here shortly.

aarongerig commented 1 year ago

@solverat Works great! You can release v1.2 if you'd like.

solverat commented 1 year ago

@aarongerig: done! https://github.com/dachcom-digital/pimcore-seo/releases/tag/v1.2.0