search

dachcom-digital / pimcore-seo

The last SEO Bundle for Pimcore you'll ever need!
Other
38 stars 14 forks source link

Respect Pimcore fallback languages #44

Closed valentin- closed 1 year ago

valentin- commented 1 year ago
Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? no

Hi, I'm currently working on a project with different regions/languages and fallback languages, f.e:

The fallback languages are useful if the same news object is used in different regions (Austria, Germany). Therefore only the title for de will be set (in the data object), and the value for de-at/de-de will be empty.

It would be handy if this feature also applies to the seo settings. Currently the value for de_AT/de_DE must be set, de won't get used as fallback.

image

What do you think about this feature?

Thanks in advance.

solverat commented 1 year ago

You're right, this should be possible!

solverat commented 1 year ago

@valentin- I just created a PR for that.

But I'm not sure if we should implement a flag to enable this feature, since this could be treated as a breaking change (new output).

Something like this maybe?

seo:
  meta_data_integrator:
    allow_locale_fallback: true # default false
solverat commented 1 year ago

We've just discussed this internally and have come to the conclusion that it does not need an additional configuration flag. This should be the standard behavior.

solverat commented 1 year ago

Fixed with #47