search

dackerman / reflex-jsx

Use jsx-like syntax in Reflex
BSD 3-Clause "New" or "Revised" License
50 stars 7 forks source link

Add basic tests #4

Closed nmattia closed 7 years ago

nmattia commented 7 years ago

I'm doing some work on a separate branch and I don't want to break anything. @dackerman have I missed a functionality?

dackerman commented 7 years ago

Hi @nmattia, this is fantastic! Thanks for adding some tests. I think we can add some more edge cases for the parser and quasiquoter at some point, but this is a great start!

I did try to run this with cabal configure --enable-tests --ghcjs && cabal test and ran into a few snags which I commented on. Also, can you add the test running command to the .travis.yml file? Currently it just runs the build.

dackerman commented 7 years ago

I'm realizing from your email that I was running on a later reflex version when testing this, hence my Text suggestions. So I guess you're right to use Strings here, but could you update the cabal file with bounds?

nmattia commented 7 years ago

I've updated the stack file to use GHC 8 and updated the code accordingly. I've also added bounds on the cabal though the code as it is now should build with both String and Text.

@dackerman For travis: would you rather build the project with nix or stack? Ideally we'd make sure it builds with both.

dackerman commented 7 years ago

@nmattia if you want to add stack build/test to travis as well, that works for me, I just want to have the tests being run in some way.

nmattia commented 7 years ago

Stack build on travis is being very picky, I'm giving up for now.

dackerman commented 7 years ago

Yeah travis is annoying to set up - really long feedback cycle. We can worry about it later - this looks good for now!