search

dacort / metabase-athena-driver

An Amazon Athena driver for Metabase 0.32 and later
Apache License 2.0
225 stars 32 forks source link

Figure out a good way to add tests #12

Closed dacort closed 1 year ago

dacort commented 5 years ago

We need a way to add a test suite.

Unfortunately this requires uploading sample data to S3 and executing Athena queries so it could be a little complex.

dacort commented 5 years ago

First example in test/driver/hive_parser_test.clj

dacort commented 5 years ago

Bumping this as it's becoming more important as we iterate.

dacort commented 4 years ago

OK, I've figured out how to do this using CircleCI and will be pushing it into master soon in #30.

However I still need to figure out how best to create/destroy the Athena test environment, so going to leave this open until I do so. For the time being, I'll just be running a small set of unit tests and possibly one integration test as well that doesn't require any DBs to be created.

dacort commented 4 years ago

We may also want to always test the latest version of Athena. Here's a snippet to download the latest release from a GitHub repo. https://gist.github.com/steinwaywhw/a4cd19cda655b8249d908261a62687f8