Add date => type/Date map

dacort / metabase-athena-driver

An Amazon Athena driver for Metabase 0.32 and later

Apache License 2.0

225 stars 32 forks source link

Add date => type/Date map #7

Closed jamarzka closed 5 years ago

jamarzka commented 5 years ago

I was getting this warning: 05-09 19:03:36 WARN driver.athena :: Don't know how to map column type 'date' to a Field base_type, falling back to :type/*.

Filtering by date still doesn't work in the query builder though: No method in multimethod 'date' for dispatch value: [:athena :day]

dacort commented 5 years ago

Ah good catch. I know there’s a bunch of different date handling code in some of the other drivers. I’ll try to take a look this coming weekend to see if I can figure out what needs to be pulled in to make date types work in the query builder.

dacort commented 5 years ago

Going to hold on merging this until I figure out how to properly handle the date type. Leaving it as a string, but still filterable seems better than marking it as a date and having the query builder break.

dacort commented 5 years ago

Closing in favor of #8 - thanks @jamarzka, feel free to take a look at the most recent version and see if that addresses things! :)

jamarzka commented 5 years ago

Nice! Your changes in #8 work great. Thanks