search

daddyz / phonelib

Ruby gem for phone validation and formatting using google libphonenumber library data
MIT License
1.06k stars 130 forks source link

Missing prefixes for PH #166

Open achowdhury7 opened 5 years ago

achowdhury7 commented 5 years ago

The following number formats are returned as invalid: +63 904-XXX-XXXX, +63 911-XXX-XXXX, +63 913-XXX-XXXX, +63 924-XXX-XXXX, +63 931-XXX-XXXX, +63 941-XXX-XXXX, +63 944-XXX-XXXX, +63 945-XXX-XXXX, +63 961-XXX-XXXX, +63 965-XXX-XXXX, +63 966-XXX-XXXX, +63 967-XXX-XXXX, +63 970-XXX-XXXX, +63 978-XXX-XXXX, +63 981-XXX-XXXX

An issue has been created on Google phonelibnumber's issuetracker for this: https://issuetracker.google.com/issues/134374016

daddyz commented 5 years ago

@achowdhury7 I updated the data from google libphonenumber. Since the issue is marked as fixed, I guess the fix is also applied to my gem. Check version 0.6.35

achowdhury7 commented 5 years ago

Hi @daddyz The following prefixes still don't work: 904, 913, 924, 941, 944, 970

Can you please help me with these? Thanks!

daddyz commented 5 years ago

Google are referencing wikipedia for PH prefixes, maybe you should try to update that page and add additional comment to your issue in google libphonenumber, since they wrote that can't accept "not an official source" which is a bit strange. Just reference this updated page there