daddyz / phonelib

Ruby gem for phone validation and formatting using google libphonenumber library data
MIT License
1.04k stars 130 forks source link

Can't parse 10 digits HK number eg`+8521234567890`. #222

Closed atsuya-kose closed 3 years ago

atsuya-kose commented 3 years ago

Python's phonenumbers can parse that.

In [2]: phonenumbers.parse("+8521234567890")
Out[2]: PhoneNumber(country_code=852, national_number=1234567890, extension=None, italian_leading_zero=None, number_of_leading_zeros=None, country_code_source=0, preferred_domestic_carrier_code=None)

But phonlib can't parse 10 digits HK number like+8521234567890.

[1] pry(main)> Phonelib.parse("+8521234567890")
=> #<Phonelib::Phone:0x0000564819b6d778
 @data={},
 @extension="",
 @national_number="8521234567890",
 @original="+8521234567890",
 @original_s="+8521234567890",
 @sanitized="8521234567890">

I checked 6,7,8,9,11 digits was working.

daddyz commented 3 years ago

@atsuya-kose This number is also parsed as invalid in original libphonenumber. You can check it here and open an issue for them. Gem's data is based on it. I have released an "additional_regexes" feature that can help to overcome this issue, refer to README.md about usage or you can also use Phonelib.override_phone_data

atsuya-kose commented 3 years ago

Oh I see. Thank you very much!!